D18487: Reparse background contrast settings when colors changed
Marco Martin
noreply at phabricator.kde.org
Tue Feb 5 16:26:29 GMT 2019
mart added inline comments.
INLINE COMMENTS
> broulik wrote in theme_p.cpp:754
> An alternative approach would be to store those values and then do the default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < 127` stuff on the fly on demand.
> It's runtime cpu cycles vs parsing a config file once on color change (with some awful copy paste)
but it wouldn't be guaranteed to be the same of the value stored in the config file no?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D18487
To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/1a29613d/attachment.html>
More information about the Kde-frameworks-devel
mailing list