D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Feb 5 16:10:02 GMT 2019


bruns added a comment.


  In D18698#405636 <https://phabricator.kde.org/D18698#405636>, @poboiko wrote:
  
  > Added code to work with first entry that pops from FilteredDirIterator (that is the directory itself)
  >  Test still works; but we should emit `created()` signal for it as well.
  
  
  Thats the reason I moved the `Q_EMIT created(...)` out of the `if(mask & IN_ISDIR)` branch.
  
  Thinking about it, it should be before the branch, otherwise baloo may receive "created" events for the children before getting a "created" for the parent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/3d253cd1/attachment.html>


More information about the Kde-frameworks-devel mailing list