D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko added a comment.


  > I am not sure if I understood your description correctly, but I am quite sure this race condition does not exist - the files/folders inside the moved folder are not created/moved one by one, but the containing folder ist just "renamed" - it is unlinked from the old parent and linked into the new one, atomically.
  
  Sure. That concern corresponded only to the second note - if moving from another device, system has to do actual copy/move.
  
  > FilteredDirIterator is somewhat odd, as it returns the traversed folder itself as the first element (if not filtered/excluded by the config).
  >  The folder itself has no fileInfo, as it is not backed by a QDirIterator item. Unfortunately, this is not really trivial to fix.
  
  Damn. I've though it's behavior is inherited from `QDirIterator`. Didn't look into `FilteredDirIterator` enough. Thanks!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/dbe452c8/attachment.html>