D18739: Sync QML module padding to reflect system setting pages
David Edmundson
noreply at phabricator.kde.org
Tue Feb 5 00:00:51 GMT 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In systemsettings 6a9df821ecfaa008206a260b20f595136e254821 <https://phabricator.kde.org/R124:6a9df821ecfaa008206a260b20f595136e254821> it was
determined that the QML KCMs should do their own padding for some
reason.
QML KCMs now do this to match what's expected in system settings.
This change was not mirrored in KMultiDialog (and hence kcmshell5)
Populating d->modules had to move in order to make sure this was
available when the first page was sadding.
TEST PLAN
Ran kcmshell5 autostart (a qwidgets module) main frame still matched where the buttons where
Ran kcmsheel5 lookandfeel (a qtquick module) main frame now matches where the buttons are
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18739
AFFECTED FILES
src/kcmultidialog.cpp
To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190205/584b7a3f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list