D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons
Andres Betts
noreply at phabricator.kde.org
Mon Feb 4 20:21:58 GMT 2019
abetts added a comment.
In D18649#405214 <https://phabricator.kde.org/D18649#405214>, @ngraham wrote:
> I want to point out that the original problem was not that the buttons lacked contrast, but that the //icons// were illegible with a variety of thumbnail contents. This problem is 100% solved by using a real button with background that uses the system color scheme in some capacity (theme-following or inverted). Whether the button backgrounds should be theme-following or inverted is an aesthetic judgment, not a usability one.
Exactly. My argument is to support the direction for usability purposes and add an aesthetic element that helps contrast. I think others in the discussion want to stop at the usability fix, I want to push that a little more and add the aesthetic element.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D18649
To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190204/ac269588/attachment.html>
More information about the Kde-frameworks-devel
mailing list