D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwritertest.cpp:409
> What are the differences between the various mp3 test cases?

It tests all possible ratings, since the commonly used numbers are somewhat arbitrary, and I wanted to make sure writing and extracting works

> bruns wrote in taglibwriter.cpp:153
> This should probably go into a separate file, togheter with the inverse transform.
> 
> This can then be tested independently, i.e.
> 
>   for rating in {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10} {
>     r = wmpRating(rating);
>     Q_ASSERT(rating = balooRating(r)); }

We have to test the rest anyway, so I don't see much benefit in this honestly.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190202/e18c95bc/attachment.html>