D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

Nathaniel Graham noreply at phabricator.kde.org
Fri Feb 1 17:43:02 GMT 2019


ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now the delegates' inline hover buttons can be very difficult to see, because they're
  (mostly) white and don't get much background contrast, and the thumbnail lightens too, further
  reducing contrast against white icons.
  
  This patch improves the situation by replacing the current geadient background bar with a
  darker semi-transparent solid color.
  
  BUG: 395510
  FIXED-IN: 5.55

TEST PLAN
  Colors KCM, before: F6581603: Colors KCM grid delegates, before <https://phabricator.kde.org/F6581603>
  
  Colors KCM, after: F6581604: Colors KCM grid delegates, after <https://phabricator.kde.org/F6581604>

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190201/e3a191e4/attachment.html>


More information about the Kde-frameworks-devel mailing list