D26318: Port endl to "\n" flush at the end + use const'ref in loop

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Dec 31 18:50:25 GMT 2019


apol added inline comments.

INLINE COMMENTS

> scalabletest.cpp:312
>              QTextStream stream(&msg);
> -            stream << "Duplicated scalable icons:" << endl;
> -            for (auto icon : duplicatedScalableIcons.keys()) {
> -                stream << QString("  %1:").arg(icon) << endl;
> -                for (auto info : duplicatedScalableIcons[icon]) {
> -                    stream << QString("    %1").arg(info.absoluteFilePath()) << endl;
> +            stream << "Duplicated scalable icons:" << "\n";
> +            for (const auto &icon : duplicatedScalableIcons.keys()) {

'\n' or merge into the string.

> scalabletest.cpp:319
>              }
> +            stream.flush();
>              QFAIL(qPrintable(msg));

Maybe add a {}-scope?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26318

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/aea43523/attachment.html>


More information about the Kde-frameworks-devel mailing list