D26300: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Dec 31 18:40:38 GMT 2019


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pidgin_emoticons.cpp:221
> +    out << QStringLiteral("Description=") + themeName() << "\n";
> +    out << "Author=" << "\n";
> +    out << "\n";

Put it in the same string as `"Author=\n"`? Or at least use '\n'.

REPOSITORY
  R301 KEmoticons

BRANCH
  port_endl_qt5.15 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26300

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/e5281c21/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list