D26294: Allow to load widget based KCMs from kcms subdir

[Aleix Pol Gonzalez]

apol added a comment.


  It would be useful if you were a bit more explicit about how you tested it on the commit message.

INLINE COMMENTS

> kcmoduleloader.cpp:103
>                  if (!cm) {
> +                    module = factory->create<KCModule>(parent, args2);
> +                    if (module) {

I see that cm is initialized with a nullptr parent. Why's it different here?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D26294

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/b8a2b3f7/attachment.html>