D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data
Luigi Toscano
noreply at phabricator.kde.org
Tue Dec 31 13:29:22 GMT 2019
ltoscano added a comment.
In D26317#585315 <https://phabricator.kde.org/D26317#585315>, @aacid wrote:
> Isn't it better to just use `Qt::endl` ?
>
> I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')`
>
> But if we prefer to change to use \n it should be merged into the existing strings, doesn't make much sense to do
> `outStream << "</l:i18n>" << QLatin1Char('\n');`
> instead of
> `outStream << "</l:i18n>\n';`
I agree with Albert here; I think it's a bit more painful but it's probably going to be cleaner.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D26317
To: mlaurent, dfaure
Cc: ltoscano, aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/146fc7b4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list