D26148: Add truncation support to FileJob

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filejob.h:109
> +     *
> +     * @param length the desired length to truncate to
> +     */

Missing @since 5.66

> filejob.h:180
> +     */
> +    void truncated(KIO::Job *job, KIO::filesize_t length);
> +

@since 5.66

> kprotocolmanager.h:477
> +     * @param url the url to check
> +     * @return true if the protocol supports truncating
> +     */

@since 5.66

> slavebase.h:209
>  
> +    void truncated(KIO::filesize_t _length);
> +

@since 5.66

> slavebase.h:481
> +     */
> +    virtual void truncate(KIO::filesize_t length);
>      /**

WARNING RED ALERT.... adding a virtual method is a binary incompatible change. This cannot be done in the 5.x timeframe.

Use a different solution, like special() or virtual_hook(). I think virtual_hook is better if the idea is to turn it into a virtual method in KF6.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26148

To: feverfew, fvogt, dfaure, sitter
Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/7301cb30/attachment-0001.html>