D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data
Anthony Fieroni
noreply at phabricator.kde.org
Tue Dec 31 07:21:10 GMT 2019
anthonyfieroni added a comment.
Will be better if you use QLatin1Char('\n'), "\n" will call strlen on which is unneeded. Also QStringLiteral is missing on some strings.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D26317
To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/6502e59c/attachment.html>
More information about the Kde-frameworks-devel
mailing list