D25877: [KColorschemeManager] Add option to reenable following global theme

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:220
> +{
> +    return createSchemeSelectionMenu(QIcon(),QString(), QString(), parent);
> +}

why not to use reasonable default values here like QIcon::fromTheme(QStringLiteral("preferences-desktop-color") and i18n("Color Scheme")? This function should be used then by all applications and this will help to get a more consistent behavior across the different applications.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191230/a47519b2/attachment-0001.html>