D26277: KFilePlaceEditDialog: move logic into isIconEditable()

Elvis Angelaccio noreply at phabricator.kde.org
Sun Dec 29 18:25:51 GMT 2019


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Instead of relying on whether `m_iconButton` has been initialized
  somewhere else in the code.

TEST PLAN
  Make sure that editing icons is still allowed only for non-Trash places.

REPOSITORY
  R241 KIO

BRANCH
  isIconEditable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26277

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp

To: elvisangelaccio, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191229/2c21ec46/attachment.html>


More information about the Kde-frameworks-devel mailing list