D25877: [KColorschemeManager] Add option to reenable following global theme

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> davidre wrote in kcolorschememanager.h:111
> Would I need to add @since for a new overload?

"Would I need"... put yourself in the shoes of a user of this class: you  would want to know at which version this new overload is available when using it in your code which sets itself a certain version of KF as minimal expected, right? :)

So yes, you want to help the users of the API to know at which versions of KF they can expect which methods and classes to be present. And thus you want to ensure "@since" with any API changes, incl. new methods added, overloaded or not.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ahmadsamir, asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191229/f07e55f5/attachment.html>