D26273: cmake: don't use taglib-config if we are cross compiling
Bhushan Shah
noreply at phabricator.kde.org
Sun Dec 29 10:31:02 GMT 2019
bshah created this revision.
bshah added a reviewer: vkrause.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bshah requested review of this revision.
REVISION SUMMARY
If we are cross compiling two things are possible,
- cmake finds host taglib-config
- cmake finds target taglib-config in sysroot
depending on toolchain configuration. In both cases taglib-config values
are useless since, we can't link to host libraries or can't run target
taglib-config in most cases.
TEST PLAN
tested it finds the taglib from sysroot when cross compiling
REPOSITORY
R286 KFileMetaData
BRANCH
bshah/cross
REVISION DETAIL
https://phabricator.kde.org/D26273
AFFECTED FILES
cmake/FindTaglib.cmake
To: bshah, vkrause
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191229/4194b7b4/attachment.html>
More information about the Kde-frameworks-devel
mailing list