D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kurlcompletion.cpp:503
>      // no protocol.  (QUrl does this only for absolute paths)
> -    if (protocol_regex.indexIn(url_copy) == 0) {
> +    if (protocol_regex.match(url_copy).hasMatch()) {
>          m_kurl = QUrl(url_copy);

hasMatch() is enough here because the pattern will only match at the beginning of the subject string because of ^ anchor.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26236

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191226/2e8e934b/attachment-0001.html>