D26133: Enable Auto Save

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> test_signal.h.ref:137
> +    /** Triggered whenever a setting changes */
> +    void configurationChanged();
> +

How about having `isSaveNeededChanged(bool)`? It could be in KCoreConfigSkeleton.

> kconfig_compiler.cpp:2121
>              }
> -            h << ");" << endl;
> +            h << ");" << endl << endl;
> +

Seems like this endl belongs outside the loop.

> kconfig_compiler.cpp:2125
> +        h << "    /** Triggered whenever a setting changes */" << endl;
> +        h << "    void configurationChanged();" << endl;
> +

If it's in every instance, it should be part of the parent class (KCoreConfigSkeleton) rather than the generated code.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26133

To: tcanabrava, ervin
Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191223/2b9dfb04/attachment.html>