D25974: Fix Invalid-enum-value assignment

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> nsCodingStateMachine.h:71
> +                                                      mModel->stateTable);
> +        if (nextCurrentState < eStart || nextCurrentState > eItsMe) {
> +            mCurrentState = eError;

eStart is 0 and GETFROMPCK returns unsigned char, so this is testing if an unsigned int is negative, can never happen.

Also, I get 9 the very first time I get here, and eItsMe is 2. It's starting to look like the enum is just a few special values, but many other values are possible?

I get 3, 5, 6, 12...

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D25974

To: aacid, dfaure
Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191223/4dbb34a0/attachment.html>