D26126: Simplify param method: Return Early, Use a Map and Assert.

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Dec 23 01:53:37 GMT 2019


apol added a comment.


  I'd make the types static const, or at least const.
  Also are you sure that here std::map is better than QHash?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26126

To: tcanabrava
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191223/c936d607/attachment.html>


More information about the Kde-frameworks-devel mailing list