D25877: [KColorschemeManager] Add option to reenable following global theme
David Redondo
noreply at phabricator.kde.org
Sun Dec 22 14:09:12 GMT 2019
davidre added a comment.
In D25877#581355 <https://phabricator.kde.org/D25877#581355>, @kossebau wrote:
> D15645 <https://phabricator.kde.org/D15645> tried something similar from what I understood without looking at details, you might want to compare at least :) Sorry, no time myself to look at things currently beyond this comment.
Thanks for the pointer! Looking at that diff what it tried to do was reading the currently active color scheme from kdeglobals. That approach has two problems imo. First it only is correct on Plasma, secondly it sets the wrong scheme when the global color scheme changes. To fix the second issue one could listen to the settings changed signal on DBus but that also only works on Plasma. Just using the `standardPalette()` is much simpler and more reliable.
REPOSITORY
R265 KConfigWidgets
BRANCH
systemthem (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25877
To: davidre, #frameworks, ngraham
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191222/cac2453a/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list