D26113: Places: For mounted volume display mount points instead of description

[Kai Uwe Broulik]

broulik added a comment.


  Not a fan of this special handling in Places. Also I think it should stay with the remote path as the fact that it's mounted locally somewhere is only an implementation detail.
  
  > Short name (mount point) should be used or this should at least be configurable.
  
  It is configurable. You can set a custom name by placing `x-gvfs-name` in fstab

INLINE COMMENTS

> kfileplacesitem.cpp:243
> +            if (m_access) {
> +                const QString path = m_access->filePath();
> +                return m_access->filePath();

This variable is superfluous

> kfileplacesitem.cpp:244
> +                const QString path = m_access->filePath();
> +                return m_access->filePath();
> +            } else {

What if it isn't mounted?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191220/e590df6f/attachment.html>