D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Code looks sane to me.
  One nitpick

INLINE COMMENTS

> managedconfigmodule.h:205
> +     * After manual registration on the fly,
> +     * it may be needed to call settingsChanged()
> +     */

Mention importance of emitting configChanged signal to automatically call settingsChanged as alternative to calling settingsChanged.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191216/07b267e9/attachment.html>