D26013: [KeySequenceHelper] Grab actual window when embedded

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Dec 15 11:24:22 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, davidre.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When used in a KCM which uses `QQuickWidget` it needs to enable grab on the render window and not the embedded container.

TEST PLAN
  - Put KeySequence thing in a KCM, I could now type a shortcut which was occupied by someone else
  - Still works in system settings (`renderWindowFor` annoyingly returns `nullptr` instead of the same window if it isn't redirected so I had to check)
  
  For simplicity I store the window in a `QPointer` to ungrab the same thing I grabbed before

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26013

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: broulik, #plasma, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191215/0dbb15f0/attachment.html>


More information about the Kde-frameworks-devel mailing list