D25972: Support PyQt5 compiled with SIP 5

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM overall

INLINE COMMENTS

> FindPythonModuleGeneration.cmake:312
>    NAMES QtCoremod.sip
> +  PATHS ${KDE_INSTALL_PYTHON3DIR}/PyQt5/bindings/QtCore
>    PATH_SUFFIXES share/sip/PyQt5/QtCore

Should probably be HINTS.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25972

To: arojas, bruns, dfaure
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191214/47d00873/attachment.html>