D25974: Fix Invalid-enum-value assignment

David Faure noreply at phabricator.kde.org
Sat Dec 14 11:44:07 GMT 2019


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Looks good otherwise.

INLINE COMMENTS

> nsCodingStateMachine.h:74
> +        } else {
> +            mCurrentState = (nsSMState)nextCurrentState;
> +        }

Please use static_cast, while at it.

C casts are horrible and should be banned, since they allow doing very bad things.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D25974

To: aacid, dfaure
Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191214/0dde87e8/attachment.html>


More information about the Kde-frameworks-devel mailing list