D15763: Set correct image attributes on directory thumbnail

David Faure noreply at phabricator.kde.org
Fri Dec 13 21:10:38 GMT 2019


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> thumbnail.cpp:730
>  
> +                KFileItem item(fileUrl);
> +

For local files, QFileInfo would be more straightforward, no?

You'd just use lastModified() on line 735 and size() on line 736.

KFileItem is mostly meant to encapsulate kioslave listDir/stat results.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15763

To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191213/865e4672/attachment.html>


More information about the Kde-frameworks-devel mailing list