D24489: KAutosaveFile not respecting maximum filename length

[Ahmad Samir]

ahmadsamir added a comment.


  FWIW, this broke kautosavefiletest:
  
    3: ********* Start testing of KAutoSaveFileTest *********
    3: Config: Using QtTest library 5.13.1, Qt 5.13.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.2.1 20190903 [gcc-9-branch revision 275330])
    3: PASS   : KAutoSaveFileTest::initTestCase()
    3: PASS   : KAutoSaveFileTest::test_readWrite()
    3: PASS   : KAutoSaveFileTest::test_fileNameMaxLength()
    3: PASS   : KAutoSaveFileTest::test_fileStaleFiles()
    3: PASS   : KAutoSaveFileTest::test_applicationStaleFiles()
    3: FAIL!  : KAutoSaveFileTest::test_locking() '!staleFiles.isEmpty()' returned FALSE. ()
    3:    Loc: [/home/ahmad/rpmbuild/dev/kcoreaddons/autotests/kautosavefiletest.cpp(148)]
    3: PASS   : KAutoSaveFileTest::cleanupTestCase()
    3: Totals: 6 passed, 1 failed, 0 skipped, 0 blacklisted, 87ms
    3: ********* Finished testing of KAutoSaveFileTest *********
    1/1 Test #3: kautosavefiletest ................***Failed    0.09 sec
  
  I've tracked it down to line 201 in kautosavefile.cpp:
  
    return QUrl::toPercentEncoding(managedFile.toLocalFile()).startsWith(encodedPath);
  
  The test_locking(), in the unit test, is using a remote file:
  
    QUrl normalFile(QString::fromLatin1("fish://user@example.com/home/remote/test.txt"));
  
  so the call to managedFile.toLocalFile() returns an empty string. Using .path() instead seems to work.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191213/604327f1/attachment.html>