D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO
Alexander Saoutkin
noreply at phabricator.kde.org
Fri Dec 13 12:32:40 GMT 2019
feverfew added a comment.
On further looking, it seems like git grep doesn't really tell the full picture. It seems like `resultingArguments` is called before `resolveURLs` is, so I've simplified the diff as requested.
INLINE COMMENTS
> feverfew wrote in desktopexecparser.cpp:331
> From what others have tested `userInfo()` is always empty even when the URL is actually a protected Samba share... This means I can't know if a certain URL is likely to have a password or not, I just have to assume it does. I'll check again just in case, as indeed it does seem odd, but that was my conclusion.
From my own testing your intuition seems correct. I've now amended my diff appropriately
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23384
To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191213/f0332d31/attachment.html>
More information about the Kde-frameworks-devel
mailing list