D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

Alexander Saoutkin noreply at phabricator.kde.org
Thu Dec 12 19:20:09 GMT 2019


feverfew added a comment.


  In D23384#572363 <https://phabricator.kde.org/D23384#572363>, @dfaure wrote:
  
  > Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun?
  >  I would expect it to have solved all this already, unless I'm missing something about the various code paths.
  >  The code you changed in krun.cpp was supposed to simply resolve desktop:/foo to file:///bleh but everything else about %u/%f is done by DesktopExecParser.
  
  
  Using git grep it seems to me that `resolveURLs` is called in `KRun::runApplicationImpl` and `KRun::runService` but `KIO::DesktopExecParser::resultingArguments` isn't called in those two functions. If URL conversion isn't necessary in those functions then I'll happily get rid of the code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191212/9f670a11/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list