D25824: Support archive installs with adoption commands
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Dec 9 20:42:07 GMT 2019
apol added inline comments.
INLINE COMMENTS
> engine.cpp:744
> + const QDir dir(currentPath);
> if (dir.path()==(rootPath+dir.dirName())) {
> + qCDebug(KNEWSTUFFCORE) << "Found directory" << dir;
Shouldn't we make sure rootPath ends with /?
at least with an ASSERT if we know it's there.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D25824
To: leinir, #frameworks, #plasma, #knewstuff, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191209/1c8aa529/attachment.html>
More information about the Kde-frameworks-devel
mailing list