D25814: [KColorScheme] Add SeparatorColor

Hugo Pereira Da Costa noreply at phabricator.kde.org
Mon Dec 9 20:20:52 GMT 2019


hpereiradacosta added a comment.


  
  
  > I'm not sure what you mean when you wonder how it would play with monochrome icons. It should have nothing to do with them unless you embed stylesheets in the SVGs to use the separator color in breeze icons.
  
  I meant: do the "light" (with window text color) toolbar icons play well with dark toolbar separators as opposed to current semi-light toolbar separators
  
  > 
  > 
  >> - in breeze and in almost all widget themes, button frames are not the same color are ordinary frames. The former uses ButtonText and ButtonBackground, the later uses WindowText and WindowBackground. By replacing this by one single color, one would effectively break all the color schemes that use different colors for these two sets.
  > 
  > Decoration colors can be customized individually for each color set, so button frames can use Button SeparatorColor.
  
  Fair point: I forgot you can specify the three different color flavors separately. Still: that makes three colors to change to make one happy with dark "separators"
  
  > Some other thoughts:
  > 
  > - Complementary SeparatorColor could be used for dark separators when a theme uses both light and dark separators or frames.
  > - I suppose I could use AlternateBackground or InactiveText instead of SeparatorColor, but that seems semantically incorrect.
  
  Agreed

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191209/ca2fe1f2/attachment.html>


More information about the Kde-frameworks-devel mailing list