D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

Filip Fila noreply at phabricator.kde.org
Sat Dec 7 22:33:42 GMT 2019


filipf added a comment.


  In D25699#573713 <https://phabricator.kde.org/D25699#573713>, @fvogt wrote:
  
  > The check for the prefix was added in `bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got added much earlier.
  >
  > The labels are visible again with just the `control.flat` condition, but the prefix one might be needed as well for non-breeze themes.
  >
  > There's a part missing though, the triangle (visible on https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is gone. That seems to be a feature lost with PC3 :-(
  
  
  Thanks for looking into the patch.
  
  Yeah, the triangle seems to be missing :/ possibly because PC2 has a menu property and PC3 doesn't... I will investigate further.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191207/32b59b74/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list