D24443: Add a plugin system
Carl Schwan
noreply at phabricator.kde.org
Sat Dec 7 22:17:11 GMT 2019
ognarb added inline comments.
INLINE COMMENTS
> dvratil wrote in calendarentry.h:63
> Use `std::unique_ptr<CalendarEntryPrivate> const d` for automatic memory management.
This wasn't done, I still see `CalendarEntryPrivate *d;`
> nicolasfella wrote in calendarplugin.h:39
> My idea was to be able to add a d-ptr later if needed without breaking ABI
Will this also work if we are using unique_ptr?
REPOSITORY
R172 KCalendar Core
REVISION DETAIL
https://phabricator.kde.org/D24443
To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191207/dcfd8dc3/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list