D25420: [KFileWidget] Avoid calling slotOk right after the url changed

[Méven Car]

meven added a comment.


  In D25420#571165 <https://phabricator.kde.org/D25420#571165>, @dfaure wrote:
  
  >
  
  
  
  
  > If KDirOperator is a child widget, and it receives and processes a key event, it can choose to NOT let the event propagate to the parent widget
  >  [by calling accept() on the QKeyEvent, or returning false from event(), or true from eventFilter(), depending on how the event is processed -- isn't Qt easy? ;-)]
  
  The issue is that QAbstractItemView::activated does not have a QEvent as parameter and it is emitted from different places.
  Meaning I can't use the Qt Event system to stop propagation of events triggering QAbstractItemView::activated, it is a Qt limitation IMO.
  So I might just move this boolean in KDirOperator or try to detect the condition when activated will be emitted, unless there is something more elegant I am missing.
  Moving the hack to KDirOperator is already somewhat cleaner.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25420

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191203/cbcc1a9d/attachment.html>