D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
Noah Davis
noreply at phabricator.kde.org
Mon Dec 2 16:32:27 GMT 2019
ndavis added a comment.
In D25677#570896 <https://phabricator.kde.org/D25677#570896>, @ngraham wrote:
> > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.
>
> Seems like these changes are unrelated and should maybe be in a separate commit?
The intention of the patch is to reduce the number of hardcoded values, so they're related. It wouldn't make sense to switch the hardcoded for-loop ranges for the enum values introduced in the parent patch only to replace them with range based for-loops immediately afterward.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D25677
To: ndavis, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191202/37c4a996/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list