D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Dec 1 12:47:19 GMT 2019


kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:56
> +        COMMAND ${CMAKE_COMMAND} -E env
> +            $<IF:$<BOOL:${MSVC}>,PATH,LD_LIBRARY_PATH>=$<TARGET_FILE_DIR:Qt5::Core>
> +            $<TARGET_FILE:qrcAlias> -i ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc -o ${RESOURCE_FILE}

This breaks builds with CMake 3.5 - 3.7, as `$<IF>` was only added for CMake 3.8.

See what the official minimum required CMake version 3.5 allows here:
https://cmake.org/cmake/help/v3.5/manual/cmake-generator-expressions.7.html

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: kossebau, ltoscano, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191201/407df18d/attachment.html>


More information about the Kde-frameworks-devel mailing list