D23619: [server] Introduce cloning and replication of output devices

Vlad Zagorodniy noreply at phabricator.kde.org
Sat Aug 31 22:22:31 BST 2019


zzag added inline comments.

INLINE COMMENTS

> zzag wrote in outputdevice.cpp:391
> That's not safe if the raw string is dynamically allocated, use qstrlen instead.

Correction: that's not reliable way to check whether a C string is empty. You assume that all empty strings have the same address, which in some cases cannot be true, e.g. if the string is dynamically allocated.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190831/e4ea5d29/attachment.html>


More information about the Kde-frameworks-devel mailing list