D23515: Format class: add functions to know if XML files set style attributes

Dominik Haumann noreply at phabricator.kde.org
Fri Aug 30 19:30:45 BST 2019


dhaumann added a comment.


  I believe you still need the hasTextColorOverride etc. hasTextColor is different and matches from the meaning isBold etc.
  
  Background: The styleOverrides are yet another concept: if the user changes a color of a highlighting in the Highlighting Text Styles tab, then the style override is active. See http://blog.case.edu/bmb12/2007/03/06/kate_styles.png
  That is: the style overrides are part of a Theme and typically only exist for Themes where the user changed colors.
  
  But: Since the port to KSyntaxHighlighting::Theme is still not done, this currently is not used (iirc ???) in KTextEditor...
  
  To make it short: if you want to know whether the colors are hardcoded, you also need the additional hasXxOverride() functions.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190830/a42f07b6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list