D23586: Improve code that detects useful elements in an Svg file

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Aug 30 16:47:34 BST 2019


apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Detect any that contains a "-[a-z]" (i.e. a dash and a lowercase letter.
  So far it was taking "digit*-digit*-anything*", which is clearly not
  enough.
  
  Also since we're already parsing the svg file in some cases, use that
  parsing to detect the interesting ids.

TEST PLAN
  Tests pass, plasma works

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23586

AFFECTED FILES
  src/plasma/svg.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190830/502078dd/attachment.html>


More information about the Kde-frameworks-devel mailing list