D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> klistopenfiles.cpp:44
> +        if (!path.exists()) {
> +            job->setError(KJob::UserDefinedError);
> +            job->emitResult();

Should I also set an error string here? And what about defining custom error codes, is that how we usually do?

> klistopenfiles.h:37
> +
> +class KCOREADDONS_EXPORT ListOpenFilesJob : public KJob
> +{

I am a little unsure if there is any other KJob functions that should be overwritten in this class? The current implementation is quite minimal, but maybe that is fine?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190829/48eb2ca0/attachment-0001.html>