D23552: ECM: remove set_package_properties from FindCanberra

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Compare though all the
  
  > Ideally this is set already directly in the Find-module.
  
  for `DESCRIPTION` and `URL` properties in the docs https://cmake.org/cmake/help/latest/module/FeatureSummary.html
  
  Which makes sense to me, at least for FindModules, where one can assume the FindX.cmake file exists, so the properties are set, and one only has to add the values for the properties `PURPOSE` and `TYPE`, as their are usage dependent.
  So in this case perhaps rather KNotifications should be adapted.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23552

To: dfaure, cgiboudeaux, sitter
Cc: kossebau, kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/993a9ed1/attachment-0001.html>