D23385: More porting from QRegExp to QRegularExpression

Daniel Vrátil noreply at phabricator.kde.org
Wed Aug 28 15:51:33 BST 2019


dvratil added inline comments.

INLINE COMMENTS

> katedocument.cpp:4676
>          foreach (const QString &pattern, wildcards) {
> -            QRegExp wildcard(pattern, Qt::CaseSensitive, QRegExp::Wildcard);
> +            QRegularExpression wildcard(QLatin1Char('^') + QRegularExpression::wildcardToRegularExpression(pattern) + QLatin1Char('$'));
>  

@dhaumann `QRegularExpression::wildcardToRegularExpression()` was introduced in Qt 5.12, but Frameworks depend on 5.11 :-( So this change breaks build...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23385

To: dhaumann, cullmann
Cc: dvratil, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/acb30212/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list