D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Harald Sitter]

sitter added a comment.


  @dfaure this is actually a different beast altogether, the current state validation is only run on the API for all slaves, seek/read/write are run in a completely different loop which I see isn't being verified at all. I'll add it in a separate diff once the assertion is in. Should be fairly trivial. As I understand it open/read/write/seek must only ever call error() or their specific "send" function (opened()/data()/written()/position()) but never finished. Close meanwhile must reach finality (finished or error).

REPOSITORY
  R320 KIO Extras

BRANCH
  fixSFTP (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/5f9dbce7/attachment.html>