D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

Méven Car noreply at phabricator.kde.org
Wed Aug 28 11:51:49 BST 2019


meven created this revision.
meven added reviewers: davidedmundson, dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Inspired by https://github.com/blue-systems/plasma-5.16/issues/139#issuecomment-441704579
  After some review, it seems to me using KConfig is not necessary here.
  Removing its use should improve IO throughput since rebuildConfig is called in finished.
  So mark the old config() function as deprecated.
  
  TODO
  
  - Discussion: does it make sense ?
  - benchmark (if anyone has some, it would be very appreciated)
  - port ioslaves in kio and kio-extras to use mapConfig() instead of config()
  - Clean up this description

TEST PLAN
  ctest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/b023a6b9/attachment.html>


More information about the Kde-frameworks-devel mailing list