D23367: make the sizing of the toolbuttons more coherent

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ToolButton.qml:56
> +                anchors.centerIn: parent
> +                height: Kirigami.Units.iconSizes.smallMedium
> +                width:  Kirigami.Units.iconSizes.smallMedium

This fixes the icons to a single size no matter what, and wether it fits or not, and is going to break badly any time a bigger or smaller buttons is needed, as shown by breaking media controller.

I have to revert this now, the icon should scale only to "standard" sizes, but still scale with the button size.
if you really need fixed icons no matter what, this size hint may follow icon.width/icon.height from the control iff set to a valid measure

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23367

To: camiloh, #plasma, mart, ngraham
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/f35f4660/attachment-0001.html>