D23344: assert slave command finality

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.cpp:67
> +#else
> +#define KIO_STATE_ASSERT(cond, where, what) qCWarning(KIO_CORE) << what
> +#endif

Don't you mean  if(!cond) { qCWarning... } ? Otherwise the warning will be shown every time, no matter what the condition says.

Or more precisely,

  do { if (!(cond)) qCWarning(KIO_CORE) << what; } while (false)

for the usual brace nesting problem.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23344

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/f461719e/attachment-0001.html>