D22144: Add kio recentlyused:/ to access KActivityStats data

Méven Car noreply at phabricator.kde.org
Wed Aug 28 06:22:42 BST 2019


meven marked 7 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in recentlyused.cpp:91
> I'm confused. Which code from ForwardingSlaveBase is this class benefiting from?
> With internalRewriteUrl returning false all SlaveBase reimplementations in that class do nothing,
> 
> If you decide not to support listing/stat'ing subdirs then indeed you don't need ForwardingSlaveBase as base class.

After more testing, inheriting from ForwardSlaveBase was not needed.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190828/80e8d8ff/attachment.html>


More information about the Kde-frameworks-devel mailing list