D23457: Port regex search to QRegularExpression

[Christoph Cullmann]

cullmann added a comment.


  In D23457#519206 <https://phabricator.kde.org/D23457#519206>, @ahmadsamir wrote:
  
  > In D23457#519205 <https://phabricator.kde.org/D23457#519205>, @cullmann wrote:
  >
  > > Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea.
  > >  Or do I misunderstand that?
  >
  >
  > It's exactly what it says, \s can match a new line char in pcre.
  >
  > Why do you think this is a bad idea?
  
  
  Because before it didn't do that in KTextEditor, or?
  That means all people that got used to the current behavior will see this as an regression, if it is not optional.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23457

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190825/eaa29f8c/attachment-0001.html>